Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file listing environment variables to documentation #1750

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

HeavyWombat
Copy link
Contributor

@HeavyWombat HeavyWombat commented Dec 13, 2024

Changes

Add GIT_SHOW_LISTING and BUNDLE_SHOW_LISTING to the default configuration to make them explicit.

Add details about GIT_SHOW_LISTING and BUNDLE_SHOW_LISTING to the configuration documentation.

Reference: shipwright-io/website#135

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

@HeavyWombat HeavyWombat added the kind/documentation Categorizes issue or PR as related to documentation. label Dec 13, 2024
@openshift-ci openshift-ci bot added the release-note-none Label for when a PR does not need a release note label Dec 13, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 13, 2024
@HeavyWombat HeavyWombat force-pushed the add/file-listing-docs branch from 8a83464 to 01d9f1c Compare December 13, 2024 15:23
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.15.0 milestone Dec 13, 2024
Add `GIT_SHOW_LISTING` and `BUNDLE_SHOW_LISTING` to the default configuration
to make them explicit.

Signed-off-by: Matthias Diester <[email protected]>
Add details about `GIT_SHOW_LISTING` and `BUNDLE_SHOW_LISTING` to the configuration documentation.

Signed-off-by: Matthias Diester <[email protected]>
@HeavyWombat HeavyWombat force-pushed the add/file-listing-docs branch from 01d9f1c to 559b131 Compare December 16, 2024 14:15
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 16, 2024
Copy link
Contributor

@karanibm6 karanibm6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2024
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karanibm6, SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8f3c7c1 into main Dec 17, 2024
21 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the add/file-listing-docs branch December 17, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants